[vector] Additional tests for binary/unary ops to bring the coverage up

[Paul Sandoz]

+1 Thank you for adding test to increase the coverage.

Paul.

> On May 28, 2020, at 2:40 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com> wrote:
> 
> Hi Paul,
>  
> Thanks for the pointer. I have updated the webrev accordingly:
> http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part1/webrev.02/ <http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part1/webrev.02/>
>  
> Best Regards,
> Sandhya
>  
> From: Paul Sandoz <paul.sandoz at oracle.com> 
> Sent: Thursday, May 28, 2020 12:25 PM
> To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
> Cc: panama-dev <panama-dev at openjdk.java.net>
> Subject: Re: [vector] Additional tests for binary/unary ops to bring the coverage up
>  
> Thanks, it should be possible to remove the newly added “Unit-*-div.template” files since they are identical to the other non div ones you added.
>  
> When I added the Kernel templates for division I managed to avoid that:
>  
> gen_op_tmpl "Binary-op_bitwise-div" "DIV+div+withMask" "a \/ b" "BITWISE"
> gen_op_tmpl "Binary-Masked-op_bitwise-div" "DIV+div+withMask" "a \/ b" “BITWISE"
>  
> …
>  
> local unit_filename="${TEMPLATE_FOLDER}/Unit-${template}.template"
> if [ ! -f $unit_filename ]; then
>   # Leverage general unit code snippet if no specialization exists
>   unit_filename="${TEMPLATE_FOLDER}/Unit-${template%_*}.template"
>   echo $unit_filename
> fi
>  
> Notice the use of the ‘_” for the start of a specialization suffix.
>  
> I think that should also work in your case.
>  
> Paul. 
> 
> 
> On May 28, 2020, at 12:10 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com <mailto:sandhya.viswanathan at intel.com>> wrote:
>  
> Hi Paul,
>  
> Added the missing files and reduced the line size in the webrev below:
> http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part1/webrev.01/ <http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part1/webrev.01/>
>  
> Best Regards,
> Sandhya
>  
> From: Paul Sandoz <paul.sandoz at oracle.com <mailto:paul.sandoz at oracle.com>> 
> Sent: Thursday, May 28, 2020 11:12 AM
> To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com <mailto:sandhya.viswanathan at intel.com>>
> Cc: panama-dev <panama-dev at openjdk.java.net <mailto:panama-dev at openjdk.java.net>>
> Subject: Re: [vector] Additional tests for binary/unary ops to bring the coverage up
>  
> Hi,
>  
> Perhaps you have a wide screen monitor like me, where it's very easy to write long lines :-) can you keep lines under 120 characters?
>  
> Did you forget to include the new kernel templates for the smoke tests?
>  
> It’s my hope that smoke tests would eventually apply to anything other than lane-wise operations accepting the operation + vector + mask, since other operations are composed from that + broadcast + blend. I would like to separate them out so that we can focus more exotic hotspot options on the relevant tests. Something to consider later.
>  
> Paul.
> 
> 
> 
> On May 27, 2020, at 6:36 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com <mailto:sandhya.viswanathan at intel.com>> wrote:
>  
> Please find below a webev which extends the test coverage for binary/unary ops of Vector API:
> http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part1/webrev.00/ <http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part1/webrev.00/>
>  
> Best Regards,
> Sandhya