[foreign-jextract] RFR: 8256080: AArch64: fatal error with unexpected intrinsic id _linkToNative

[Maurizio Cimadamore]

On Tue, 10 Nov 2020 10:49:13 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> AArch64 doesn't implement linkToNative yet. However during VM startup
>> several of the MethodHandles methods are called with the _linkToNative
>> intrinsic ID. Add minimal handling of this (taken from x86) to avoid
>> fatal errors.
>
> I'm surprised to hear that this is what's causing the problems. We don't have any handling for _linkToNative in e.g. sharedRuntime_x86_32.cpp in gen_special_dispatch either, but that doesn't seem to be a problem for a 32-bit build (with some additional fixes).
> 
> I also didn't expect this code to be called before linking a _linkToNative call. I'm curious to know where the calls during startup are coming from.
> 
> Any ways, thanks for debugging and fixing. The only comment I have is that this should go into the foreign-abi branch, so please change the target branch.

Thanks for this! I'm currently testing the patch. One thing I noted is that this PR has been filed against the `foreign-jextract` branch and not the `foreign-abi` one which would be more appropriate.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/391