[foreign-abi] RFR: 8256466: MemoryLayout factories do not guard against null layouts [v2]

Jorn Vernee jvernee at openjdk.java.net
Mon Nov 23 10:55:09 UTC 2020


On Fri, 20 Nov 2020 19:26:25 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch fixes the remaining issues with NPE in javadoc and implementation in the foreign-abi branch. For testing only few extra lines in the harness were required, the most difficult part being the VaList/Builder stuff (since these are scopd abstractions which can only be used in a certain way).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added checks for FunctionDescriptor

Marked as reviewed by jvernee (Committer).

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/FunctionDescriptor.java line 127:

> 125:         Objects.requireNonNull(resLayout);
> 126:         Objects.requireNonNull(argLayouts);
> 127:         Objects.requireNonNull(argLayouts);

Redundant check here?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/399


More information about the panama-dev mailing list