[foreign-memaccess] RFR: 8252504: Add a method to MemoryLayout which returns a offset-computing method handle [v2]

Tue Nov 24 15:17:14 UTC 2020

On Thu, 19 Nov 2020 18:39:12 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Looks good - added some javadoc/test suggestions
>
> This looks good.  It is true to say that `bitOffset`/`byteOffset` do not accept any path elements with free dimensions? If so, then it would be good to call this out explicitly - I cannot find it in the API.

I've updated this PR to:
- Add tests for multiple sequences: https://github.com/openjdk/panama-foreign/pull/396/commits/798cf6ffeb9bbf6908cae1e984d8b20dbad1aaba
- Simplify the implementation to use the existing `strides` array: https://github.com/openjdk/panama-foreign/pull/396/commits/8ccdb94bf3ed476c88a6182095ebb13a1fa72093
- Touch up the javadoc: https://github.com/openjdk/panama-foreign/pull/396/commits/e8ceb119a77fab16d4072dcd371d6d74f1d2d305
- Merge with upstream, which replaces the explicit `null` tests with TestNulls.

Please have another look, thanks.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/396