[foreign-memaccess] Integrated: 8257075: MemoryAcccess methods are missing @ForceInline annotations

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Nov 25 15:17:11 UTC 2020


On Wed, 25 Nov 2020 12:39:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch adds missing `@ForceInline` annotations to the various accessors in the `MemoryAccess` class. The lack of said annotations causes performance to deteriorate when many calls to the static accessors are packed into a single hot method.
> I've also added a new benchmark to verify that unrolled loops using memory access API (whether usingVH directly, or statics in `MemoryAccess`) are on par with unsafe access. This benchmark is heavily borrowed from a benchmark submitted
> by Antoine Chambille (thanks!):
> 
> https://mail.openjdk.java.net/pipermail/panama-dev/2020-November/011444.html

This pull request has now been integrated.

Changeset: c51cb7c6
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/c51cb7c6
Stats:     194 lines in 2 files changed: 194 ins; 0 del; 0 mod

8257075: MemoryAcccess methods are missing @ForceInline annotations

Reviewed-by: jvernee, chegar

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/401


More information about the panama-dev mailing list