[vectorIntrinsics] RFR: 8254826: Add reduction nodes implementation for Arm SVE [v2]

Dongbo He dongbohe at openjdk.java.net
Thu Oct 22 06:58:19 UTC 2020


On Thu, 22 Oct 2020 06:29:42 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

>> Dongbo He has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix style problems
>
> src/hotspot/cpu/aarch64/aarch64_sve.ad line 1348:
> 
>> 1346:   predicate(UseSVE > 0 && n->in(2)->bottom_type()->is_vect()->length_in_bytes() >= 16 &&
>> 1347:             (n->in(2)->bottom_type()->is_vect()->element_basic_type() == T_SHORT ||
>> 1348:             (n->in(2)->bottom_type()->is_vect()->element_basic_type() == T_CHAR)));
> 
> As Andrew said in my patch review, does it make sense to have T_CHAR here: https://github.com/openjdk/jdk/pull/726#discussion_r507726726?

I think it can be consistent with other structs first, and then modify together in the main line

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/13


More information about the panama-dev mailing list