[foreign-jextract] RFR: 8252700: jextract ignores typedef to undefined structs

Maurizio Cimadamore mcimadamore at openjdk.java.net
Fri Sep 4 09:35:02 UTC 2020


On Fri, 4 Sep 2020 03:24:50 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> A class with annotated allocatePointer methods is generated

Looks good.
I note a mild inconsistencies in the sense that, in most emitXYZ the annotation is passed from outside, while in
emitTypeDef the annotation is calculated internally.

I believe this way is totally the right way to go and that, currently, the various source builders are too "stringy"
so, perhaps in the future, we can clean up some of the code by always genertating metadata in the source builders
rather than output factory, and pass more types/declarations around.

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/307


More information about the panama-dev mailing list