[foreign-jextract] RFR: 8252931: Extend multiple constant classes support to ClassConstantHelper [v2]
Jorn Vernee
jvernee at openjdk.java.net
Wed Sep 9 10:41:42 UTC 2020
On Wed, 9 Sep 2020 10:10:56 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Have a separate constants per class limit for binary generation
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/MultiFileConstantHelper.java line 38:
>
>> 36: public class MultiFileConstantHelper implements ConstantHelper {
>> 37:
>> 38: private static final int CONSTANTS_PER_CLASS = Integer.getInteger("jextract.constants.per.class", 1000);
>
> This limit was empirically found by running source constant helper on samples (like lapack, python, libgit2). I'd
> recommend doing similar experiment with binary constant helper and arrive at suitable threshold.
I've updated the code. The limit for binary generation is set to 10000 (found by extracting Windows.h)
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/314
More information about the panama-dev
mailing list