RFR: 8252964: [vectorIntrinsics] jdk/incubator/vector/Short64VectorTests.java crashes on AVX512 machines

[jiefu(傅杰)]

Hi Sandhya and Paul,

Thanks for your review and comments.

Updated: http://cr.openjdk.java.net/~jiefu/8252964/webrev.01/

I won't push it into the hg-repo.
I'd like to create a pr once the git-repo is ready.

Thanks.
Best regards,
Jie

On 2020/9/10, 6:17 AM, "Viswanathan, Sandhya" <sandhya.viswanathan at intel.com> wrote:

    Hi Jie,
    
    Thanks for looking into this issue. The patch looks good. One comment, you can now also merge the two rules (reductionS, reduction32S) into one by adjusting the predicate.  As Paul mentioned below, let us wait for the move to Git repo.
    
    Best Regards,
    Sandhya
    
    -----Original Message-----
    From: panama-dev <panama-dev-retn at openjdk.java.net> On Behalf Of Paul Sandoz
    Sent: Wednesday, September 09, 2020 8:48 AM
    To: "jiefu(傅杰)" <jiefu at tencent.com>
    Cc: panama-dev at openjdk.java.net
    Subject: Re: RFR: 8252964: [vectorIntrinsics] jdk/incubator/vector/Short64VectorTests.java crashes on AVX512 machines
    
    HI Jie,
    
    Thanks for looking a t this. A note on logistics, I will the intel folks review.
    
    Please hold off pushing to the hg repository. We are in the process of transitioning to a git repo, and I want to ensure both the git and hg repos are on sync when transitioning.
    
    Paul.
    
    > On Sep 9, 2020, at 5:40 AM, jiefu(傅杰) <jiefu at tencent.com> wrote:
    > 
    > Hi all,
    > 
    > JBS:    https://bugs.openjdk.java.net/browse/JDK-8252964
    > Webrev: http://cr.openjdk.java.net/~jiefu/8252964/webrev.00/
    > 
    > Short64VectorTests.java was observed crashed on AVX512 machines.
    > The reason is that the vtmp1 [1] register which will be used by Assembler::phaddw should be legVec.
    > 
    > The fix changes src2/vtmp1/vtmp2 [1] from vec to legVec just as reduction32S [2].
    > 
    > Testing:
    >    jdk/incubator/vector on AVX512 machines
    > 
    > Thanks.
    > Best regards,
    > Jie
    > 
    > [1] 
    > http://hg.openjdk.java.net/panama/dev/file/34b4be5c12d4/src/hotspot/cp
    > u/x86/x86.ad#l4640 [2] 
    > http://hg.openjdk.java.net/panama/dev/file/34b4be5c12d4/src/hotspot/cp
    > u/x86/x86.ad#l4660