[foreign-abi] RFR: 8248560: Specify the behaviour of the ForeignLinker returned by CSupport::getSystemLinker [v2]

[Jorn Vernee]

On Tue, 15 Sep 2020 20:24:38 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments:
>>   - remove C_BOOL
>>   - CLinker javadoc changes
>>   - rename CLinker::getSystemLinker to CLinker::getInstance()
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 144:
> 
>> 142:      * The prefix of all ABI attribute names.
>> 143:      */
>> 144:     String ABI_ATTR_PREFIX = "abi/";
> 
> does this go here? Not sure what it buys to clients.

I added this for fixing jextract. Jextract needs to filter out these attributes before making condys, since otherwise
you get an access error when resolving. So, I thought that specifying a common name prefix would be the best way to
make that possible, without exposing the actual attribute names that need to be filtered.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/327