[foreign-abi] RFR: 8248560: Specify the behaviour of the ForeignLinker returned by CSupport::getSystemLinker [v2]

Jorn Vernee jvernee at openjdk.java.net
Wed Sep 16 10:12:22 UTC 2020


On Tue, 15 Sep 2020 20:34:51 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments:
>>   - remove C_BOOL
>>   - CLinker javadoc changes
>>   - rename CLinker::getSystemLinker to CLinker::getInstance()
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 418:
> 
>> 416:      * and any other type that fits into a {@code long}.
>> 417:      */
>> 418:     interface VaList extends Addressable, AutoCloseable {
> 
> Comment about sealedness and immutability here - probably for the Builder too

Can do sealed, but neither VaList and Builder impls are immutable.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/327


More information about the panama-dev mailing list