[foreign-abi] RFR: 8248560: Specify the behaviour of the ForeignLinker returned by CSupport::getSystemLinker [v2]

[Jorn Vernee]

On Wed, 16 Sep 2020 03:18:36 GMT, Michael Ennen <mennen at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments:
>>   - remove C_BOOL
>>   - CLinker javadoc changes
>>   - rename CLinker::getSystemLinker to CLinker::getInstance()
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 73:
> 
>> 71:  *
>> 72:  *   <li>If the carrier type is {@code MemoryAddress}, then the corresponding memory layout must be a
>> 73:  *   {@code ValueLayout}, and its bit size must match the platform's address size (see {@link
>> MemoryLayouts#ADDRESS}).
> 
> super minor grammatical thing, I think "and its bit size" is more correct as "and its' bit size"

"its" already is the possessive form, "its'"seems to be a misspelling: https://en.wiktionary.org/wiki/its%27

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/327