[foreign-abi] RFR: 8248560: Specify the behaviour of the ForeignLinker returned by CSupport::getSystemLinker [v4]
Jorn Vernee
jvernee at openjdk.java.net
Wed Sep 16 12:29:12 UTC 2020
On Wed, 16 Sep 2020 12:20:35 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove public attribute name prefix
>
> Tests add @module clauses. Perhaps not needed - earlier code too used those classes and imports. We had global config
> for those modules? Perhaps that could be removed now that we've specific tests having @module. Not super critical
> though.
@sundararajana The @modules is needed to export the internal jdk.internal.foreign package, since the tests are now
relying on the internal CABI enum for determining the current platform (previously they were using the
ForeignLinker::name) method.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/327
More information about the panama-dev
mailing list