[foreign-abi] RFR: 8239780: FunctionDescriptor factories and combinators should check whether return layout is null

[Athijegannathan Sundararajan]

On Thu, 17 Sep 2020 10:41:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> I'm going through the foreign-abi JBS issues and taking care of some of the open ones.
> 
> This PR adds null checking to the MemoryLayouts passed to the FunctionDescriptor factories and adapter methods,
> together with a simple test.
> I've also added an adapter for dropping the return layout, since with the null check, it is no longer possible to pass
> `null` to drop the return layout. I think having the explicit check, and a separate combinator for dropping the return
> layout instead will be better for avoiding accidental nulls being used.  Thanks,
> Jorn

test/jdk/java/foreign/TestFunctionDescriptor.java line 60:

> 58:         fd.changeReturnLayout(null); // should throw
> 59:     }
> 60:

Test for dropReturnLayout missing?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/330