[foreign-abi] Integrated: 8239780: FunctionDescriptor factories and combinators should check whether return layout is null

Jorn Vernee jvernee at openjdk.java.net
Thu Sep 17 14:08:19 UTC 2020


On Thu, 17 Sep 2020 10:41:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> I'm going through the foreign-abi JBS issues and taking care of some of the open ones.
> 
> This PR adds null checking to the MemoryLayouts passed to the FunctionDescriptor factories and adapter methods,
> together with a simple test.
> I've also added an adapter for dropping the return layout, since with the null check, it is no longer possible to pass
> `null` to drop the return layout. I think having the explicit check, and a separate combinator for dropping the return
> layout instead will be better for avoiding accidental nulls being used.  Thanks,
> Jorn

This pull request has now been integrated.

Changeset: 4e74387b
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/4e74387b
Stats:     164 lines in 2 files changed: 0 ins; 164 del; 0 mod

8239780: FunctionDescriptor factories and combinators should check whether return layout is null

Reviewed-by: sundar

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/330


More information about the panama-dev mailing list