[foreign-abi] RFR: 8233007: Add upcall tests that test stack arguments on Windows [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Fri Sep 18 15:18:17 UTC 2020


On Fri, 18 Sep 2020 14:31:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> This PR adds a test for high-arity upcalls.
>> 
>> This actually uncovered a bug in the Windows CallArranger wrt passing structs by-value on the stack, which I've fixed.
>> I've also added the particular test case to the CallArranger test.
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
> excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since
> the last revision:
>   Add a test for high-arity upcalls

Looks good

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/342


More information about the panama-dev mailing list