[foreign-abi] RFR: Turn on downcall intrinsics by default [v2]

[Jorn Vernee]

On Tue, 22 Sep 2020 14:18:04 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since
>> the last revision:
>>  - Merge branch 'foreign-abi' into Default_Intrinsics
>>  - More stack tests
>>  - Enable intrinsics by default
>>  - Dissable intrinsics for stack arguments
>
> Looks good - I wonder if we should add (either here, or in a separate changeset) a test for high arity downcalls - we
> can verify correctness by generating all combinations:
> m1(a1, a2 ..... an) { return a1; }
> ...
> mn(a1, a2 ..... an) { return an; }
> 
> What do you think?

@mcimadamore Thanks for the suggestion. I've refactored the test a bit and implemented it, but if I re-enable stack
arguments some of the test cases fail; exactly the ones that are testing the arguments passed on the stack.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/354