[foreign-jextract] RFR: 8253725: Jextract fails to extract big monolithic headers [v2]
Jorn Vernee
jvernee at openjdk.java.net
Mon Sep 28 18:36:08 UTC 2020
On Mon, 28 Sep 2020 17:39:47 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> I see what you mean. Right now, one piece of messiness is that the class contents are attached to either class
>> begin/end, w/o much discipline. I'll see what I can do.
>
> I did some investigation here - and it doesn't seem like adding extra structure here is worth it. Adding build might
> risk (if we make it general) to conflict with HeaderBuilder.build which does a different task.
> As for `addStuff` while in principle that's obvious, in practice that's a bundle of static code that we want to
> generate with the class - so if we go for that we're asking all clients to do classBegin/addStuff/classEnd
> (OutputFactory would be affected badly). So, yes, as is it looks awful, but I think we should try to fix it in a more
> radical rewriting of this code.
Ok, sounds good
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/357
More information about the panama-dev
mailing list