[foreign-abi] RFR: 8253255: Investigate replacing ABI layout attributes with custom subtypes of ValueLayout

Jorn Vernee jvernee at openjdk.java.net
Tue Sep 29 11:05:58 UTC 2020


On Mon, 28 Sep 2020 17:04:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> ```
> Layout v = (ValueLayout)other;
> 102         return order.equals(v.order) &&
> 103             bitSize() == v.bitSize() &&
> 104             alignment == v.alignment;
> 105     }
> ```
> 
> 
> Let's maybe add a test on this.

Thanks, for catching this! I had forgotten to add equals & hashCode methods to the new class. Will add a test as well.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/358


More information about the panama-dev mailing list