[foreign-abi] RFR: 8253796: Consider making CValueLayout public. [v3]
Jorn Vernee
jvernee at openjdk.java.net
Tue Sep 29 16:58:36 UTC 2020
On Tue, 29 Sep 2020 16:04:34 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move CValueLayout factories to PlatformLayouts
>
> Looks good - except for missing javadoc
I've added javadoc now.
I made some Kind.bsm() private since it could be, and moved the factory methods to PlatformLayouts, since that's the
only place they were being used (had to make the constructor public for that, but that doesn't seem like a problem?).
Finally, I also added an isFloat() function to Kind in order to complete the set of predicates (should this also be
implemented using a boolean flag?)
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/359
More information about the panama-dev
mailing list