[foreign-jextract] RFR: 8253798: Simplify ClassConstantHelper

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Sep 29 19:49:31 UTC 2020


On Tue, 29 Sep 2020 18:45:17 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> This patch removes a whole bunch of workarounds in jextract code, which are made possible by upstream changes to
> foreign-abi.
> ClassConstantHelper no longer has to manually canonicalize MemoryLayout constant that represent layout constants in
> CLinker. This is now handled by the CValueLayout.describeConstable() override.
> Making CValueLayout public also means we can remove the CanonicalField enum from jextract, and rely on the
> CValueLayout.Kind instead. (note that since the enum was internal, complex recursive filtering would be needed if we
> had kept it).  Thanks,
> Jorn

Looks good!

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/360


More information about the panama-dev mailing list