[vectorIntrinsics] RFR: 8264469: Add Insert float nodes implementation for Arm SVE

Wang Huang whuang at openjdk.java.net
Thu Apr 1 03:24:32 UTC 2021


On Wed, 31 Mar 2021 09:28:42 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 line 1923:
>> 
>>> 1921: VECTOR_INSERT(B, iRegIorL2I, B, Register)
>>> 1922: VECTOR_INSERT(S, iRegIorL2I, H, Register)
>>> 1923: VECTOR_INSERT(I, iRegIorL2I, S, Register)
>> 
>> I'm sorry that I didn't look at the implementation PR for integer type. Is it better to merge the rules for "B/H/S" as a single one?
>
>> I'm sorry that I didn't look at the implementation PR for integer type. Is it better to merge the rules for "B/H/S" as a single one?
> 
> Agree. I plan to do some cleanup work before integrating to jdk mainline, which will include such kind of merging. If @Wanghuang-Huawei can do it in this patch, that would help to reduce future refactoring work.

It's a good idea. However, we can not comment the type info after merging, so I choose this implementation.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/56


More information about the panama-dev mailing list