[vector] New branch created vectorIntrinsics+mask

Xiaohong Gong Xiaohong.Gong at arm.com
Fri Apr 2 02:50:51 UTC 2021


Hi Ningsheng, Sandhya,

Yes, since my initial masking support patch depends on the predicate register allocation and mask type definition (added in Jatin's patch), I'd like to push two separate commits in one PR:

1) The register allocation and type definition part.
     This commit mainly contains the SVE predicate register allocation. For the shared part, we will simply resolve the conflicts with Jatin's patch. 
     We can refine this part in detail after Jatin's patch is merged. 
2) The basic masking support patch without any backend implementation.
     This is the main codes according to Sandhya's suggestion. And we can start the review from this part. 

Thanks,
Xiaohong

-----Original Message-----
From: Ningsheng Jian <ningsheng.jian at arm.com> 
Sent: Friday, April 2, 2021 9:52 AM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Xiaohong Gong <Xiaohong.Gong at arm.com>
Cc: Paul Sandoz <paul.sandoz at oracle.com>; panama-dev at openjdk.java.net; Vladimir Ivanov <vladimir.x.ivanov at oracle.com>; Bhateja, Jatin <jatin.bhateja at intel.com>
Subject: Re: [vector] New branch created vectorIntrinsics+mask

Hi Sandhya,

Agree that we need to move faster for JDK17, but I think the type definition has some impact to the IR shape. Just taking some part of Xiaohong's patch may bring some confusion for the review. Maybe we can take original RFC code as it, and merge Jatin's patch later. But I will leave Xiaohong for the final decision.

Thanks,
Ningsheng

On 4/1/21 10:29 PM, Viswanathan, Sandhya wrote:
> Hi Ningsheng,
> 
> These are two independent components: Jatin's mainline patch and the part that I requested below from Xiaohong. No overlap between the two.
> We want to move as fast as possible if we want to make JDK 17.
> 
> Best Regards,
> Sandhya
> 
> 
> -----Original Message-----
> From: Ningsheng Jian <ningsheng.jian at arm.com>
> Sent: Thursday, April 01, 2021 12:26 AM
> To: Xiaohong Gong <Xiaohong.Gong at arm.com>; Viswanathan, Sandhya 
> <sandhya.viswanathan at intel.com>
> Cc: Paul Sandoz <paul.sandoz at oracle.com>; panama-dev at openjdk.java.net; 
> Vladimir Ivanov <vladimir.x.ivanov at oracle.com>; Bhateja, Jatin 
> <jatin.bhateja at intel.com>
> Subject: Re: [vector] New branch created vectorIntrinsics+mask
> 
> Hi,
> 
> I see Jatin's JDK-8262355 (https://github.com/openjdk/jdk/pull/2768) is almost ready to merge. Can we get that patch synced into the new branch now, so that Xiaohong can rebase her code to that for review?
> 
> Thanks,
> Ningsheng
> 
> On 4/1/21 2:27 PM, Xiaohong Gong wrote:
>> Hi Sandhya,
>>
>> Thanks for the advice! I will create a PR to the new branch! Thanks!
>>
>> Best Regards,
>> Xiaohong
>>
>> -----Original Message-----
>> From: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
>> Sent: Thursday, April 1, 2021 7:49 AM
>> To: Xiaohong Gong <Xiaohong.Gong at arm.com>; Ningsheng Jian 
>> <Ningsheng.Jian at arm.com>
>> Cc: Paul Sandoz <paul.sandoz at oracle.com>; 
>> panama-dev at openjdk.java.net; Vladimir Ivanov 
>> <vladimir.x.ivanov at oracle.com>; Bhateja, Jatin 
>> <jatin.bhateja at intel.com>
>> Subject: RE: [vector] New branch created vectorIntrinsics+mask
>>
>> Hi Xiaohong,
>>
>> Please create a pull request containing only changes to the following files as a first step towards masking support for this new branch (vectorIntrinsics+mask).
>> 1) *.java
>> 2) *.ad with Matcher::match_rule_supported_masked_vector() set as 
>> false for every architecture
>> 3) The changes to the following files if and as needed to create the blend node as before:
>>        vmIntrinsics.hpp, c2compiler.cpp, classes.hpp, lcm.cpp, 
>> library_call.hpp, node.hpp, vectorIntrinsics.cpp, 
>> vectornode.cpp/.hpp, vmStructs.cpp
>>
>> We can then review this part and get it checked in as soon as possible.
>>
>> Best Regards,
>> Sandhya
>>
>> -----Original Message-----
>> From: panama-dev <panama-dev-retn at openjdk.java.net> On Behalf Of Paul 
>> Sandoz
>> Sent: Wednesday, March 31, 2021 10:31 AM
>> To: panama-dev at openjdk.java.net' <panama-dev at openjdk.java.net>
>> Subject: [vector] New branch created vectorIntrinsics+mask
>>
>> Hi,
>>
>> I created a new branch:
>>
>>     
>> https://github.com/openjdk/panama-vector/tree/vectorIntrinsics+mask
>>
>> branching from:
>>
>>     https://github.com/openjdk/panama-vector/tree/vectorIntrinsics
>>
>> Where we can collaborate on the vector mask work, without perturbing any work in vectorIntrinsics. Should hopefully make collaboration easier and faster.
>>
>> Paul.
>>
> 



More information about the panama-dev mailing list