[vectorIntrinsics+mask] RFR: 8264563: Add masked vector intrinsics for binary/store operations [v2]

[Xiaohong Gong]

On Wed, 7 Apr 2021 05:54:09 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert changes of register allocation and new added mask IRs
>
> src/hotspot/share/opto/vectornode.cpp line 763:
> 
>> 761:     return value->bottom_type()->is_vect();
>> 762:   }
>> 763:   // The value input is actually a BinaryNode, which has two inputs value and mask.
> 
> BinaryNodes are created just before selection. In other cases a vector binary operation should be store's input value and its bottom_type() must be a valid vector type. Did you see any failure/issue for which this special handling for Binarynode is added?

Yes, this issue is caused due to the matcher puts the third and forth inputs into a BinaryNode before matching. See: https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/src/hotspot/share/opto/matcher.cpp#L2348

The issue will happen when `vect_type()` is called after then (i.g. in the ad file).

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/57