[vectorIntrinsics] RFR: 8265321: Add Rearrange nodes implementation for Arm SVE
Ningsheng Jian
njian at openjdk.java.net
Mon Apr 19 08:33:50 UTC 2021
On Mon, 19 Apr 2021 08:24:45 GMT, Wang Huang <whuang at openjdk.org> wrote:
>> Agree with @nsjian . I prefer to merge all these rules into one as we have discussed too much times before, as there is no instruction difference for different types. Anyway, we can have a separate patch to unify the styles in ad file.
>
>> Some cases are different, but I don't think we need to distinguish floating point data types for this operation as they are actually the same thing and generate the same code.
>
> Yes, I think for this rule `L` and `D` have the same form. However, the comment itself should be consistent with others. In other case, we should distinguish floating point data types. That is why I choose to use `L` instead of `D`.
If you really want to have a correct comment, you can comment as something like "(L/D)" - though I doubt if it really make any sense for your testing/debugging.
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/70
More information about the panama-dev
mailing list