[foreign-memaccess+abi] RFR: Investigate alternate strategy to acquire resource scopes [v3]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Wed Apr 21 18:21:53 UTC 2021
On Wed, 21 Apr 2021 17:41:28 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'foreign-memaccess+abi' into acquire_release_scope
>> - Add reachability fence on ResourceScope::release
>> - Initial push
>
> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/ResourceScopeImpl.java line 131:
>
>> 129: try {
>> 130: Objects.requireNonNull(handle);
>> 131: if (!isImplicit() && handle.scope() != this) {
>
> Is this check correct, since an implicit scope could accept a handle from a non-implicit scope?
yeah - something is off here
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/511
More information about the panama-dev
mailing list