[foreign-jextract] RFR: MemorySegmentPool + Allocator [v7]
Radoslaw Smogura
github.com+7535718+rsmogura at openjdk.java.net
Thu Apr 22 01:55:38 UTC 2021
On Wed, 21 Apr 2021 23:37:15 GMT, Radoslaw Smogura <github.com+7535718+rsmogura at openjdk.org> wrote:
>> (Preview)
>>
>> The MemorySegmentPool is a pool maintaining memory segments, optionally can expose allocator which can be bound to other scope, and which will return allocated segments back to pool.
>>
>> However the best results has been achieved by using getSegmentEntry & putSegmentEntry methods.
>>
>> The pool is intended to be used by long running applications (i.e. like global shared pool), where fast allocation and de-allocation of segments is critical (was designed during implementation of I/O subsystem with Panama, as a pool for temporary buffers between system I/O methods and Java byte arrays from InputStreams).
>>
>> The pool uses hand-made SpinLockQueue as the Deque from JDK offers too much functionality and overhead.
>
> Radoslaw Smogura has updated the pull request incrementally with two additional commits since the last revision:
>
> - Better releasing resources on scopes close
> New benchamarks for bulk allocations
> - Minor fixes to SpinLockQueue
> Remove redundant LOCK release (set to 0) in put entry.
> Fixed maxSize comparison
> Removed unused imports
>
> Q: Could we reduce setRelease to just set in few places?
> Q: Should this method be private and moved to Entry.close to prevent accidental adding element from other queue?
I made a change to test, and results look strange.
Looks like using pooled buffer is very slow. I think this is something what was pointed out during test with StrLen, but now this phenomena can be better observed when manipulating number of read bytes.
I can't find right now what causes this.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/509
More information about the panama-dev
mailing list