[vectorIntrinsics] RFR: 8265312: Unsigned comparison operators [v2]

Jatin Bhateja jbhateja at openjdk.java.net
Thu Apr 22 05:21:32 UTC 2021


On Wed, 21 Apr 2021 17:25:11 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Add unsigned comparison operators to VectorOperators and add intrinsic support on x64.
>
> Paul Sandoz has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge pull request #6 from sviswa7/unsigned-comparison-operators
>    
>    Implement review comments from Jatin
>  - Implement review comments from Jatin

Rest of the changes looks good to me, thanks!

src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 2199:

> 2197:     vpcmpCCW(dst, vtmp1, vtmp2, comparison, Assembler::Q, vlen_enc, scratch);
> 2198:     vpermilps(dst, dst, 8, vlen_enc);
> 2199:     vpermpd(dst, dst, 8, vlen_enc);

Hi @sviswa7 , since vector compare is happening in integer domain and subsequent in-lane and cross lane operations in floating point domain using PSHUFD and VPERMQ we should be able to save additional cycles due cross domain switchover.

-------------

Marked as reviewed by jbhateja (Committer).

PR: https://git.openjdk.java.net/panama-vector/pull/68


More information about the panama-dev mailing list