[foreign-memaccess+abi] Integrated: Misc javadoc fixes

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Apr 22 18:13:34 UTC 2021


On Thu, 22 Apr 2021 14:30:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This short patch addresses some API review comments which have been raised by @jbf.
> 
> Following changes are made:
> 
> * addOnClose is renamed to addCloseAction, to remove ambiguity on when `add` happens
> * some comments about allocation confinement and thread safety have been moved in the arenaAllocator factory (from the top level javadoc)
> * The text in the thread-confinement section of `ResourceScope` has been massaged a little to describe how clients are expected to deal with issues when closing shared scopes in a more positive way (e.g. the new text suggests what to do "Add more synchronization" instead of saying "it's a bug"). The rewritten section also connects more nicely with what comes later (resource scope handles) which are all about avoiding close vs. access races.

This pull request has now been integrated.

Changeset: c2812d9e
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/c2812d9e
Stats:     28 lines in 6 files changed: 9 ins; 4 del; 15 mod

Misc javadoc fixes

Reviewed-by: chegar

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/515


More information about the panama-dev mailing list