[foreign-memaccess+abi] RFR: 8278151: Heap segments should handle alignment constraints in a deterministic fashion [v2]

Radoslaw Smogura duke at openjdk.java.net
Thu Dec 2 14:58:42 UTC 2021


On Thu, 2 Dec 2021 14:50:05 GMT, Radoslaw Smogura <duke at openjdk.java.net> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add benchmarks for aligned access
>
> src/java.base/share/classes/java/lang/invoke/X-VarHandleMemoryAccess.java.template line 119:
> 
>> 117:         long address = base + offset;
>> 118:         long maxAlignMask = bb.maxAlignMask();
>> 119:         if (skipAlignmentMaskCheck && maxAlignMask == 0) {
> 
> I've got minor comment. I wonder if we can skip `skipAlignmentMaskCheck` parameter and just base on `maxAlignMask`

Sorry, it was stupid question. Please ignore

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/622


More information about the panama-dev mailing list