[foreign-jextract] RFR: 8261642: improve jextract source generation mode and remove class generation [v2]
Jorn Vernee
jvernee at openjdk.java.net
Mon Feb 15 15:22:45 UTC 2021
On Mon, 15 Feb 2021 14:06:39 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/ConstantBuilder.java line 267:
>>
>>> 265: append(")");
>>> 266: } else if (l instanceof GroupLayout) {
>>> 267: if (((GroupLayout) l).isStruct()) {
>>
>> Good place to use `instanceof` pattern matching.
>
> true
You missed the ValueLayout and SequenceLayout cases?
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/450
More information about the panama-dev
mailing list