[vectorIntrinsics] RFR: 8261108: Add cast nodes from integer types to float types implementation for Arm SVE

[Wang Huang]

On Thu, 18 Feb 2021 03:19:35 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

>> Add the backend codegen for nodes like castb2f / castb2d / casts2f / casts2d / casti2f / casti2d / castl2f / castl2d.
>> 
>> * add `sve_scvtf`  ( and `sve_ucvtf`) encoding
>> * add mock for these instructions
>> * add `VECTOR_CAST_I2F_EXTEND[N]` and `VECTOR_CAST_I2F`
>> 
>> Thank you for your review.
>
> src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 line 1634:
> 
>> 1632: %}')dnl
>> 1633: dnl             $1 $2 $3       $4 $5 $6 $7
>> 1634: VECTOR_CAST_I2F_EXTEND3(B, D, sunpklo, H, S, D, scvtf)
> 
> Can you please align the comment $1...$7 to the arguments?

Thank you for your review. I will fix this.

> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 3356:
> 
>> 3354: #undef INSN
>> 3355: 
>> 3356:   void encode_cvtf_T (SIMD_RegVariant& T_dst, SIMD_RegVariant& T_src) {
> 
> It's better to be a non-public function.

Yes, I will fix it.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/37