[vectorIntrinsics] RFR: 8261394: [vector] Crash with "assert(Matcher::vector_size_supported(elem_bt, length)) failed: length in range" [v2]

[Jie Fu]

On Fri, 19 Feb 2021 08:31:11 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> The crash is introduced by [1] and happens when the compiler is making an unspported vector type:
>>   assert(Matcher::vector_size_supported(elem_bt, length)) failed: length in range
>> Before vectorization for each vector intrinsic, the hotspot will check whether current arch supports the vector operation from several aspects like the backend implementation, the vector type and length. Once one of them is not matched, the compiler will stop the vectorization and go back to the default java implementation.
>> 
>> The changes in [1] missed the check for "Op_CallLeafVector". I think the double 64-bits vector is not supported to be vectorized. However, due to the missing check, the compiler continues the progress and then the crash happens.
>> 
>> This patch fixes it by making sure the check contains all opcodes.
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8261267
>
> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add vector size check for "Op_CallLeafVector"

Looks good to me.
Thanks for fixing it.

-------------

Marked as reviewed by jiefu (no project role).

PR: https://git.openjdk.java.net/panama-vector/pull/38