[vectorIntrinsics] RFR: 8261108: Add cast nodes from integer types to float types implementation for Arm SVE [v2]
Ningsheng Jian
njian at openjdk.java.net
Sat Feb 20 02:09:50 UTC 2021
On Fri, 19 Feb 2021 08:49:00 GMT, Wang Huang <whuang at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 3385:
>>
>>> 3383: pgrf(Pg, 10), rf(Zn, 5), rf(Zd, 0); \
>>> 3384: encode_cvtf_T(T_dst, T_src); \
>>> 3385: f(T_dst, 23, 22), f(T_src, 18, 17); \
>>
>> I would suggest to fill the bits in order, i.e. move f(T_dst, 23, 22) right after (... 31, 24), and then (21, 19), (18, 17)...
>
> `T_dst` and `T_src` will be changed after `encode_cvtf_T`, so they cannot move there.
I think it's fine to assign the values at the beginning. And maybe you can add more test cases to check different combinations.
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/37
More information about the panama-dev
mailing list