[foreign-memaccess+abi] RFR: 8262118: Specialize upcalls [v2]
Jorn Vernee
jvernee at openjdk.java.net
Tue Feb 23 14:16:55 UTC 2021
On Tue, 23 Feb 2021 10:50:59 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ProgrammableInvoker.java line 243:
>>
>>> 241:
>>> 242: if (bufferCopySize > 0) {
>>> 243: specializedHandle = SharedUtils.wrapWithAllocator(specializedHandle, argAllocatorPos, bufferCopySize, false);
>>
>> The variable leafType in this method is unused (I couldn't leave the comment there - for some reason GitHub doesn't allow me to add comments outside the highlighted areas...)
>
> +1 for dedicated TWR routine - which is now cleanly shared by upcall and downcall logic.
Thanks, will remove the leafType variable.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/457
More information about the panama-dev
mailing list