[foreign-jextract] RFR: 8260583: jextract generates redundant constant files

[Athijegannathan Sundararajan]

On Thu, 28 Jan 2021 12:10:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> When testing performances of jextract generated code with big headers, I noticed that jextract was emitting empty constant files. After some debugging, I realized that the issues lies in the fact that `ConstantHelper::build` is called both by `ToplevelBuilder::build` and by `HeaderFileBuilder::build` - so, for every new header file split that is generated, we trigger a new constant file, even though that is not needed.
> 
> The solution is to remove the call from `HeaderFileBuilder` and just keep the one inside `TopLevelBuilder`.

Marked as reviewed by sundar (Committer).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/440