[foreign-memaccess+abi] RFR: Add stack walk test case that doesn't verify oops
Vladimir Ivanov
vlivanov at openjdk.java.net
Thu Jan 28 18:52:56 UTC 2021
On Wed, 16 Dec 2020 14:25:45 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> This is a followup for the earlier quickfix of: https://github.com/openjdk/panama-foreign/pull/417
>
> This adds another test case to TestStackWalk that catches the failing code path.
>
> This re-uses the previously added `WhiteBox::verifyFrames`, and adds a flag to turn off the verification, which triggers the problematic code path. (I've also renamed this to just `walkFrames`, since now we don't always do verification anymore.
src/hotspot/share/prims/whitebox.cpp line 2293:
> 2291: tty->print_cr("[WhiteBox::WalkFrames] Walking Frames");
> 2292: }
> 2293: for (StackFrameStream fst(JavaThread::current(), verify_oops, true); !fst.is_done(); fst.next()) {
Can you elaborate, please, why `verify_oops` is equivalent to `RegisterMap::_update_map`?
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/423
More information about the panama-dev
mailing list