[foreign-memaccess+abi] RFR: Add stack walk test case that doesn't verify oops

Jorn Vernee jvernee at openjdk.java.net
Fri Jan 29 12:15:56 UTC 2021


On Fri, 29 Jan 2021 12:00:40 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> src/hotspot/share/prims/whitebox.cpp line 2293:
>> 
>>> 2291:     tty->print_cr("[WhiteBox::WalkFrames] Walking Frames");
>>> 2292:   }
>>> 2293:   for (StackFrameStream fst(JavaThread::current(), verify_oops, true); !fst.is_done(); fst.next()) {
>> 
>> Can you elaborate, please, why `verify_oops` is equivalent to `RegisterMap::_update_map`?
>
> If the register map is not updated, we can't do the call to `frame::verify` below that, which currently only verifies oops in the frame. I thought that the name `verify_oops` would best describe the functionality of the parameter in general, but maybe I've got that backwards... I use it specifically to turn off `RegisterMap::_update_map` after all.

Renaming this to `update_reg_map_and_verify_oops` a bit of a mouth full maybe, but want to make clear that oop verification only happens when the flag is set.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/423


More information about the panama-dev mailing list