[foreign-memaccess+abi] RFR: 8270851: Logic for attaching/detaching native threads could be improved

Maurizio Cimadamore mcimadamore at openjdk.java.net
Fri Jul 16 16:52:35 UTC 2021


For a complete description of the issue, please refer to:

https://bugs.openjdk.java.net/browse/JDK-8270851

This patch makes the logic for detaching native threads more lazy - by only doing the detach when a native thread has completed. This is achieved by using some thread local storage, which is used to keep track of the Java thread associated to a given native thread. If, by the time the thread local storage is destroyed, we see that a Java thread has been attached, we do a detach operation. This trick effectively minimizes the number of Thread instances created when interacting with multi-threaded native code.

This patch also tweaks the logic for attaching native threads to the VM by using the "daemon" attach variant. That is, native threads registered against the VM (because of Panama upcalls) should not prevent the JVM to shut down in an orderly fashion (in cases where the native threads might outlive the JVM).

-------------

Commit messages:
 - Remove whitespaces, fix indent
 - Lazily deattach native threads using thread local storage destructors

Changes: https://git.openjdk.java.net/panama-foreign/pull/570/files
 Webrev: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=570&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8270851
  Stats: 45 lines in 3 files changed: 21 ins; 19 del; 5 mod
  Patch: https://git.openjdk.java.net/panama-foreign/pull/570.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/570/head:pull/570

PR: https://git.openjdk.java.net/panama-foreign/pull/570


More information about the panama-dev mailing list