[vectorIntrinsics+mask] RFR: 8271273: Java API and IR changes for masked compare operation [v2]

[Paul Sandoz]

On Tue, 27 Jul 2021 10:37:27 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> - Re-organized the Java API implementation to use one common entry point of masked/non-masked vector compare operation.
>> - Intrinsic side changes to absorb newly passed mask if target support predicated instructions else handled appropriately by performing vector AND b/w comparison result and explicit mask.
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8271273: Review comments resolution.

Looking better, just a small tweak for full consistency with the other template methods.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java line 1916:

> 1914:         ByteSpecies vsp = vspecies();
> 1915:         ByteVector that = (ByteVector) v;
> 1916:         that.check(this);

Suggestion:

        ByteVector that = (ByteVector) v;
        that.check(this);
        m.check(maskClass, this);


And similarly for the non-mask accepting method (we don't need the explicit null check and vsp is not used).

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/103