[foreign-memaccess+abi] RFR: Check for mixed access - remove mem barriers
Paul Sandoz
psandoz at openjdk.java.net
Tue Jul 27 18:38:43 UTC 2021
On Sat, 24 Jul 2021 16:07:09 GMT, Radoslaw Smogura <github.com+7535718+rsmogura at openjdk.org> wrote:
> That's for previous PR, which I destroyed with bad merge from master.
>
> I wonder if this can look like this?
>
>
> Benchmark (size) Mode Cnt Score Error Units
> ByteBufferVectorAccess.directBuffers 1024 avgt 10 27.119 ? 0.186 ns/op
> ByteBufferVectorAccess.heapBuffers 1024 avgt 10 28.501 ? 0.118 ns/op
> ByteBufferVectorAccess.pollutedBuffers 1024 avgt 10 64.354 ? 27.778 ns/op
> Finished running test 'micro:ByteBufferVectorAccess'
>
>
> https://github.com/openjdk/panama-foreign/pull/566
I think we need to have a base comparison with `VarHandle` access to a byte buffer, not in terms of performance but when barriers occur or not. I believe we should be able to push the unpolluted base+offset vector heap and direct accesses into `LibraryCallKit::inline_vector_mem_operation`.
Re: repo, sorry i assumed you were aware of the different panama repos, to be precise this one: https://github.com/openjdk/panama-vector/tree/vectorIntrinsics
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/573
More information about the panama-dev
mailing list