[vectorIntrinsics] RFR: 8266720: Wrong implementation in LibraryCallKit::inline_vector_shuffle_iota [v3]

Wang Huang whuang at openjdk.java.net
Wed Jun 2 08:05:07 UTC 2021


> Because JDK-8266317 has not been merged into jdk/jdk. So I fix this bug here.
> * This comparsion should be a unsigned cmp
> *  `x86` is not wrong because `x86` does not have 1024-bits vl here. 
>   ```c++
> 
>     ConINode* pred_node = (ConINode*)gvn().makecon(TypeInt::make(BoolTest::ge)); // should BoolTest::ugt
>     Node * lane_cnt  = gvn().makecon(TypeInt::make(num_elem));
>     Node * bcast_lane_cnt = gvn().transform(VectorNode::scalar2vector(lane_cnt, num_elem, type_bt));
>     // should BoolTest::ugt
>     Node* mask = gvn().transform(new VectorMaskCmpNode(BoolTest::ge, bcast_lane_cnt, res, pred_node, vt));

Wang Huang has updated the pull request incrementally with one additional commit since the last revision:

  only fix IR

-------------

Changes:
  - all: https://git.openjdk.java.net/panama-vector/pull/81/files
  - new: https://git.openjdk.java.net/panama-vector/pull/81/files/781d67cb..bd17e1dc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=panama-vector&pr=81&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=panama-vector&pr=81&range=01-02

  Stats: 27 lines in 5 files changed: 13 ins; 13 del; 1 mod
  Patch: https://git.openjdk.java.net/panama-vector/pull/81.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-vector pull/81/head:pull/81

PR: https://git.openjdk.java.net/panama-vector/pull/81


More information about the panama-dev mailing list