[foreign-memaccess+abi] Integrated: 8267989: Exceptions thrown during upcalls should be handled

Jorn Vernee jvernee at openjdk.java.net
Wed Jun 2 13:09:47 UTC 2021


On Mon, 31 May 2021 17:39:41 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> This patch regularizes exception handling for exceptions thrown during upcalls. Exceptions thrown during upcalls are now always handled by printing out the stack trace and then calling `System::exit` (see the JBS issue for some motivation).
> 
> I've added some documentation for the exception handling to `CLinker::upcallStub`, as well as a new public `int` constant in `CLinker` which is the error code that is passed to `System::exit`. The returned error code can also be configured by a system property, which for now is mostly useful for testing purposes to make sure we don't get a consistent false positive.
> 
> Thanks,
> Jorn

This pull request has now been integrated.

Changeset: d1b8b670
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/d1b8b67021f037b362780354b4caa0b77e9c6e29
Stats:     385 lines in 17 files changed: 324 ins; 21 del; 40 mod

8267989: Exceptions thrown during upcalls should be handled
8268031: VarHandle combinator check for exceptions is too strict

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/543


More information about the panama-dev mailing list