[vectorIntrinsics] RFR: 8244490: [vector] Move Vector API micro benchmarks under test/micro [v5]

[Paul Sandoz]

On Tue, 8 Jun 2021 16:32:25 GMT, Marcus G K Williams <mgkwill at openjdk.org> wrote:

>> Vector API micro benchmarks are currently located under test/jdk/jdk/incubator/vector/benchmark which makes them rather as "dead" code without possibility to built and run.
>> 
>> The proper location for micro benchmarks is actually test/micro/ directory.
>> It would be nice to move Vector API benchmarks there so they can be built automatically as part 'test-image' make target.
>> Once they are built they can be run as
>>  make run-test TEST=micro:BENCHMARK_TEST_NAME
>
> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Standardize copyright header, add 2021
>   
>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>

Thank you. Looks good. Just fix the license headers before integrating.

Now we have the benchmarks integrated into the build system we can consider what it means to "curate".

I am wondering if we should package the vector benchmarks as a separate jar to the other benchmarks. It might sound strange to say that given they were separate to begin with! but they were not integrated with the build system. That likely requires changes to the build system and discussion with the maintainers of the build system. We can start that conversation after integration.

We can follow up with the `DecodeBench.java` issue after integration.

test/jdk/jdk/incubator/vector/BENCHMARKS.md line 1:

> 1: Benchmarks generated to test/micro/org/openjdk/bench/jdk/incubator/vector/operation

Could you add a link/details on how to configure the build so JMH is included?

test/jdk/jdk/incubator/vector/templates/Perf-Scalar-header.template line 2:

> 1: /*
> 2:  * Copyright (c) 2018, 2020, 2021, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.


We just use one year or the range. Hopefully not too tedious to change with a global search and replace.

-------------

Marked as reviewed by psandoz (Committer).

PR: https://git.openjdk.java.net/panama-vector/pull/77