[foreign-memaccess+abi] RFR: 8268673: Stack walk across optimized entry frame on fresh native thread fails [v2]

[Jorn Vernee]

On Mon, 14 Jun 2021 12:38:03 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> When native code creates a new thread and calls a Panama upcall, and during that upcall a stack walk is triggered, getting the sender frame for the entry frame is not possible, and should not be attempted.
>> 
>> For JNI this case is handled already by indicating the end of the stack frame stream, but for Panama upcalls it is not, and the VM will either hit an assert or crash when trying to find the last Java frame before the entry frame (which does not exist in this case).
>> 
>> This patch adds handling for panama upcalls frames to `frame::is_first_frame`, which is used by the stack walking code to determine when to stop walking.
>> 
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missing from previous commit

test/jdk/java/foreign/stackwalk/TestAsyncStackWalk.java line 2:

> 1: /*
> 2:  *  Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 *  Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.

test/jdk/java/foreign/stackwalk/libAsyncStackWalk.cpp line 2:

> 1: /*
> 2:  *  Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 *  Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/558