[foreign-memaccess+abi] RFR: Add support for high-level functions to copy to and from Java arrays [v7]

[Uwe Schindler]

On Fri, 25 Jun 2021 11:15:39 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch includes some of the changes from Lee to support a set of static functions to allow bulk copy from Java arrays to segments (and viceversa) in a more succint fashion (so that the user doesn't have to create a temporary heap segment to do the copy).
>> 
>> I've added a new public method to `MemorySegment` which performs an *element-wise* bulk copy; it takes a source segment and a couple of element layouts: the source element layout and the destination element layout. The two layouts must have same size, but can have different alignments (which will be checked against the corresponding segments) and byte orders. If the byte order differs, a bulk copy with swap will be performed. As such, this method generalizes the previous `copyFrom` - as follows:
>> 
>> 
>> copyFrom(srcSegment) -> copyFrom(JAVA_BYTE, srcSegment, JAVA_BYTE)
>> 
>> I've added support for argument type profiling for MemoryCopy static methods to avoid type pollution in cases where same metod is called with different memory segment types.
>> 
>> I've done a pass over the javadoc, and make it more consistent with the rest of the API. I've also reworked the test a bit to use the data provider functionality of TestNG, since all the test cases were similar, except for the carrier type.
>> 
>> There are other cosmetic changes as well, compared to original code from Lee, such as naming of static fields which is now capitalized. Everything else is the same.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove argument type profiling for MemoryCopy methods

Hi,
Wouldn't it make sense to change MemoryCopy test to use a read-only source segment, so we ensure that the access checks are correct? The first bug I found was that it tried to check for write access on the copy source.

I left a comment where the check could be integrated into the test.

Otherwise, looks fine to me. I have no strong preference on the parameter order, but I would prefer System.arrayCopy style.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/555