[foreign-memaccess+abi] RFR: Add support for high-level functions to copy to and from Java arrays [v4]
Uwe Schindler
uschindler at openjdk.java.net
Fri Jun 25 12:59:10 UTC 2021
On Tue, 22 Jun 2021 14:23:08 GMT, Uwe Schindler <uschindler at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix wrong polarity of readOnly in copyTo methods
>
> test/jdk/java/foreign/TestMemoryCopy.java line 119:
>
>> 117: arr[i] = (byte)i;
>> 118: }
>> 119: return MemorySegment.ofArray(arr);
>
> This segment should be made readonly, to assert all checkAccess() calls.
Ok - you added this to slice, e.g. here. I have overseen this! https://github.com/openjdk/panama-foreign/pull/555/files#diff-cf69e75a9e792b2f93dec150609654fe2dc3b4f3b45a8fbdca1b5b450d52173bR82
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/555
More information about the panama-dev
mailing list