[vectorIntrinsics+mask] RFR: 8269282: Add masking support for vector gather_load/scatter_store [v2]

Xiaohong Gong xgong at openjdk.java.net
Tue Jun 29 08:44:17 UTC 2021


On Tue, 29 Jun 2021 07:47:06 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix MacOS x64 build failure issue
>
> src/hotspot/share/opto/vectornode.hpp line 849:
> 
>> 847:   LoadVectorGatherMaskedNode(Node* c, Node* mem, Node* adr, const TypePtr* at, const TypeVect* vt, Node* indices, Node* mask)
>> 848:     : LoadVectorNode(c, mem, adr, at, vt) {
>> 849:     init_class_id(Class_LoadVector);
> 
> class ID set at Class_LoadVector will prevent usage of [is/isa/as]_LoadVectorGatherMasked. it should be set as Class_LoadVectorGatherMasked with appropriate changes in node.hpp, but we can defer it for now till actual usages of such APIs are needed in code base.

Yes, absolutely! I used `class_LoadVector` mainly because currently we doesn't need any usage of s/isa/as]_LoadVectorGatherMasked. This could be updated in future if needed! Thanks for you review @jatin-bhateja !

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/95


More information about the panama-dev mailing list