[foreign-jextract] RFR: 8262733: jextract generates clashing names which results in compilation error with javac

[Maurizio Cimadamore]

On Mon, 1 Mar 2021 11:07:15 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> name clash is avoided by checking surrounding class names

hardwiring the choice of the parameter name to the builder seems odd, and will probably not scale when structs will feature functions with multiple parameters

src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/StructBuilder.java line 58:

> 56:         this.structType = structType;
> 57:         prefixElementNames = new ArrayDeque<>();
> 58:         safeParameterName = isEnclosedBySameName("x")? "x$" : "x";

I'm not sure by this. It seems very tailored to the issue you have found. I guess I'd prefer a function like:
String safeParameterName(String paramName)

Which can be called by clients. Note that when we'll add support for calling function pointers (https://git.openjdk.java.net/panama-foreign/pull/456) structs will also have "functions" (which allow to call a function pointer); these function have more than one parameter, each of which could probably clash with any of the enclosing classes. So, in short, I think all parameter names in nested classes should probably be guarded by similar code.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/462