[foreign-jextract] RFR: 8261511: jextract fails to handle name clashes between unrelated constants [v2]

[Maurizio Cimadamore]

On Wed, 10 Mar 2021 14:54:03 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> constants class is nested properly. piggybacking to fix long whitespace string in pretty printer
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   code review suggestion to avoid additional nested class for structs

Looks good - as discussed offline there is a risk (present already) that reusing structs as constant holder might end up with scalability issues (e.g, if a struct has too many fields) so we probably will have to keep an eye on this.

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/468